Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Introduce ResourceSupplier SPI #1672

Closed
wants to merge 1 commit into from

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Nov 9, 2018

Overview

Addresses part of #1555 by providing a new default extension handling @New and @Singleton annotations.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #1672 into master will decrease coverage by 0.8%.
The diff coverage is 3.29%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1672      +/-   ##
===========================================
- Coverage     91.71%   90.9%   -0.81%     
- Complexity     4102    4105       +3     
===========================================
  Files           351     355       +4     
  Lines          9743    9834      +91     
  Branches        778     786       +8     
===========================================
+ Hits           8936    8940       +4     
- Misses          619     707      +88     
+ Partials        188     187       -1
Impacted Files Coverage Δ Complexity Δ
...it/jupiter/engine/extension/ExtensionRegistry.java 94.23% <ø> (ø) 23 <0> (ø) ⬇️
...ava/org/junit/platform/commons/util/FileUtils.java 0% <0%> (ø) 0 <0> (?)
.../junit/jupiter/api/extension/ResourceSupplier.java 0% <0%> (ø) 0 <0> (?)
...va/org/junit/jupiter/api/support/io/Temporary.java 0% <0%> (ø) 0 <0> (?)
...er/engine/extension/ResourceSupplierExtension.java 10.71% <10.71%> (ø) 3 <3> (?)
...jupiter/engine/execution/ExtensionValuesStore.java 91.17% <0%> (+1.47%) 21% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 614a934...1c2d8b4. Read the comment docs.

@sormuras sormuras force-pushed the issues/1555-singleton-resource branch 3 times, most recently from 36a06ed to a2c161d Compare November 10, 2018 09:31
@sormuras sormuras force-pushed the issues/1555-singleton-resource branch from a2c161d to 389c7e6 Compare January 19, 2019 15:45
@sormuras sormuras force-pushed the issues/1555-singleton-resource branch from 389c7e6 to 34d1515 Compare January 19, 2019 16:32
@sormuras sormuras force-pushed the issues/1555-singleton-resource branch 2 times, most recently from 92ca99f to 1bfd7a3 Compare January 27, 2019 06:30
This commit also provides Temporary, an implementation that creates
and deletes temporary directories. The Temporary.Directory annotation
can be used as an abbreviation for `@New(Temporary.class)`.

Addresses #1555
@sbrannen
Copy link
Member

sbrannen commented Feb 5, 2019

Closing due to suggested move to JUnit Pioneer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants