Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method reference in CollectionUtils javadoc #3013

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

kirmerzlikin
Copy link
Contributor

@kirmerzlikin kirmerzlikin commented Aug 24, 2022

Overview

There was an invalid method reference in the javadoc for CollectionUtils.toStream method. This invalid reference caused aggregateJavadocs task to fail, which in turn failed the whole CI build (example - https://github.com/junit-team/junit5/runs/7990513854?check_suite_focus=true).

This PR fixes that invalid method reference.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@kirmerzlikin kirmerzlikin changed the title Fix method reference in CollectionUtils javadoc Fix CI build failing due to invalid method reference in javadoc Aug 24, 2022
@kirmerzlikin kirmerzlikin changed the title Fix CI build failing due to invalid method reference in javadoc Fix CI build failing because of the invalid method reference in the javadoc Aug 24, 2022
Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sormuras sormuras merged commit e9dff5b into junit-team:main Aug 24, 2022
@sormuras
Copy link
Member

Thanks for another fix, Kyrylo! Much appreciated.

@sbrannen
Copy link
Member

Thanks for the fix!

I've back ported this to 5.9.x for inclusion in 5.9.1.

@sbrannen sbrannen changed the title Fix CI build failing because of the invalid method reference in the javadoc Fix method reference in CollectionUtils javadoc Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants