Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document concurrency considerations for TestExecutionListener implementations #3053

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

edysli
Copy link
Contributor

@edysli edysli commented Oct 6, 2022

Overview

This PR integrates @marcphilipp 's comment as a note in TestExecutionListener's Javadoc. There are no code changes.

Are there other documents to update as well (guide)?

Fixes: #2539


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

Add a note about concurrency considerations for
`TestExecutionListener` implementations to this interface's Javadoc.

Issue: junit-team#2539
Co-authored-by: Marc Philipp <mail@marcphilipp.de>
Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edysli
Copy link
Contributor Author

edysli commented Oct 10, 2022

Thanks for the review @sormuras ! 😄
Would you mind labelling this PR with “hacktoberfest-accepted”, so that it counts toward my Hacktoberfest 2022 effort?

@sormuras sormuras added the hacktoberfest-accepted https://hacktoberfest.com/participation/#maintainers label Oct 10, 2022
@sormuras sormuras merged commit 4a87980 into junit-team:main Oct 10, 2022
@sormuras
Copy link
Member

Labelled and merged. Thanks Etienne!

@sbrannen sbrannen changed the title Document concurrency considerations for TestExecutionListener implementations Document concurrency considerations for TestExecutionListener implementations Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document concurrency considerations for TestExecutionListener implementations
3 participants