Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stream counterparts to ReflectionSupport utility methods returning List #3084

Merged
merged 13 commits into from
Dec 16, 2022
Merged

Add Stream counterparts to ReflectionSupport utility methods returning List #3084

merged 13 commits into from
Dec 16, 2022

Conversation

Ndione24
Copy link
Contributor

@Ndione24 Ndione24 commented Nov 5, 2022

Overview

Resolves #2779

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@Ndione24 Ndione24 marked this pull request as ready for review November 5, 2022 14:44
@juliette-derancourt juliette-derancourt marked this pull request as draft November 9, 2022 16:16
@Ndione24 Ndione24 marked this pull request as ready for review November 14, 2022 22:22
@sbrannen sbrannen mentioned this pull request Nov 15, 2022
Closed
juliette-derancourt
juliette-derancourt requested changes Nov 16, 2022
View reviewed changes
Copy link
Member

@juliette-derancourt juliette-derancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ndione24, thank you for your contribution! 🎉
It looks good, I left comments about minor documentation issues, and one implementation improvement :)

documentation/src/docs/asciidoc/release-notes/release-notes-5.10.0-M1.adoc Outdated Show resolved Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/support/ReflectionSupport.java Show resolved Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/support/ReflectionSupport.java Outdated Show resolved Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/support/ReflectionSupport.java Outdated Show resolved Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/util/ReflectionUtils.java Outdated Show resolved Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/util/ReflectionUtils.java Outdated Show resolved Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/util/ReflectionUtils.java Outdated Show resolved Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/util/ReflectionUtils.java Outdated Show resolved Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/util/ReflectionUtils.java Outdated Show resolved Hide resolved
@juliette-derancourt juliette-derancourt changed the title Add ReflectionSupport.findFieldsAsStream method Add Stream counterparts to ReflectionSupport utility methods returning List Dec 16, 2022
@juliette-derancourt juliette-derancourt merged commit 16de26f into junit-team:main Dec 16, 2022
@juliette-derancourt
Copy link
Member

Thanks for the PR @Ndione24! 🎉
This has been merged to main 👍

juliette-derancourt added a commit that referenced this pull request Dec 16, 2022
@juliette-derancourt
Edit comments and release notes added in #3084
d7a52e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliette-derancourt juliette-derancourt juliette-derancourt approved these changes

Assignees
No one assigned
Labels
component: Jupiter component: Platform theme: extensions theme: programming model type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Stream counterparts to ReflectionSupport utility methods returning List
2 participants
@Ndione24 @juliette-derancourt