Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow potentially unlimited maxCharsPerColumn in Csv{File}Source #3924

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

marcphilipp
Copy link
Member

Resolves #3923.

@marcphilipp marcphilipp self-assigned this Aug 13, 2024
Co-authored-by: Christian Stein <sormuras@gmail.com>
Copy link
Member

@sormuras sormuras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor documentation style suggestions - implementation and test looks good.

@marcphilipp marcphilipp merged commit 9430ece into main Aug 13, 2024
15 checks passed
@marcphilipp marcphilipp deleted the marc/3923-unrestricted-maxCharsPerColumn branch August 13, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@CsvFileSource is unusable for datasets involving very long lines
2 participants