Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github logo #256

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add github logo #256

wants to merge 1 commit into from

Conversation

Kyliux
Copy link
Contributor

@Kyliux Kyliux commented Dec 30, 2024

did my best

Couldnt get to use the github_pink.svg in static :/ mb

@peterpeterparker
Copy link
Contributor

peterpeterparker commented Dec 30, 2024

Thanks for the PR. Unfortunately, this is semantically incorrect. An <a> element cannot be a descendant of another <a> element. If we want to make this change, the card structure needs to be reworked. The card should contain two separate links, and for the CSS, we could potentially use the :has() selector to highlight the card. Additionally, we need to ensure that clicking on the GitHub link does not trigger the main call-to-action.

Side note: For the icons we can use svg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants