Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parseQuery.js #147

Merged
merged 3 commits into from
Sep 23, 2023
Merged

Update parseQuery.js #147

merged 3 commits into from
Sep 23, 2023

Conversation

psyfreak
Copy link
Contributor

add handling of textIndex / search for a phrase, which could be wrongly detected as a date

add handling of textIndex / search for a phrase, which could be wrongly detected as a date
Copy link
Owner

@jupe jupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you implement unit test as well?

@psyfreak
Copy link
Contributor Author

yes, sorry actually it is my first pr ever on a open source repo ;)

@jupe
Copy link
Owner

jupe commented Sep 23, 2023

hmm, what is wrong with circle 🙄

@jupe jupe merged commit 73318a6 into jupe:master Sep 23, 2023
2 checks passed
@psyfreak
Copy link
Contributor Author

Should I help you with something here?

@jupe
Copy link
Owner

jupe commented Sep 25, 2023

I didn’t have time to look at the circleci. I guess it just didn’t triggered because 3rd party committer. I took risk and merge 😁 functionality work fine but there was trivial style issue witch prevent me to create release.Any change you could fix them (npm run lint)?

@psyfreak
Copy link
Contributor Author

psyfreak commented Sep 25, 2023

only to clarify I got the following eslint issues (mainly crlf linebreaks etc. and around 160 function use instead of arrow function)
✖ 1523 problems (1443 errors, 80 warnings)
1438 errors and 0 warnings potentially fixable with the --fix option.

I am wondering if this project was linted with this version before or do I sth. wrong?

I added a new PR after I saw the circleCI output.
I am not sure, but is the eslint setup used, which circle CI is using, because my IDE generates a way more output with the .eslint file in the root folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants