-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parseQuery.js #147
Update parseQuery.js #147
Conversation
add handling of textIndex / search for a phrase, which could be wrongly detected as a date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you implement unit test as well?
yes, sorry actually it is my first pr ever on a open source repo ;) |
hmm, what is wrong with circle 🙄 |
Should I help you with something here? |
I didn’t have time to look at the circleci. I guess it just didn’t triggered because 3rd party committer. I took risk and merge 😁 functionality work fine but there was trivial style issue witch prevent me to create release.Any change you could fix them (npm run lint)? |
only to clarify I got the following eslint issues (mainly crlf linebreaks etc. and around 160 function use instead of arrow function) I am wondering if this project was linted with this version before or do I sth. wrong? I added a new PR after I saw the circleCI output. |
add handling of textIndex / search for a phrase, which could be wrongly detected as a date