-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪓 Split Output
into Outputs
→ Output[]
#1671
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 90ac03d The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Nov 22, 2024
agoose77
force-pushed
the
agoose77/feat-future-ast-outputs
branch
3 times, most recently
from
November 25, 2024 10:56
dba90de
to
ae6a292
Compare
agoose77
commented
Nov 25, 2024
agoose77
force-pushed
the
agoose77/feat-future-ast-outputs
branch
4 times, most recently
from
November 25, 2024 11:50
e278262
to
1f3a8c2
Compare
agoose77
changed the title
⬆️🤫 Lift and parse Markdown/text outputs from Jupyter outputs (option 2)
⬆️🤫 Split Nov 25, 2024
Output
into Outputs -> Output[]
agoose77
changed the title
⬆️🤫 Split
🪓 Split Nov 25, 2024
Output
into Outputs -> Output[]
Output
into Outputs -> Output[]
agoose77
force-pushed
the
agoose77/feat-future-ast-outputs
branch
from
January 14, 2025 14:06
1f3a8c2
to
48e8edd
Compare
agoose77
force-pushed
the
agoose77/feat-future-ast-outputs
branch
from
January 14, 2025 14:14
48e8edd
to
b257932
Compare
agoose77
changed the title
🪓 Split
🪓 Split Jan 16, 2025
Output
into Outputs -> Output[]
Output
into Outputs
→ Output[]
This was referenced Jan 20, 2025
Closed
From meeting:
|
Closing this in favour of a rework as a simple package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1674 by introducing two new versions (
1*
and2
) of the MyST AST:Version
2
Version
1*
This PR does the following things with these AST types:
1*
and2
in input data (e.g..myst.json
or XRefs) and upgrade it to version 22
1*
(to avoid breaking old consumers)The idea here is to start publishing a modified version of the current schema that is forward-compatible (version
1*
) ASAP. Then, at some future moment, we will trigger an AST upgrade and start publishing version2
in a future build of MyST.Versions of
mystmd
that include #1671 will recognise this AST, and have no problems in handling it.Warning
Upgrading from
1
to2
is a lossy process — there is no obvious way to figure out whichoutput.children
belong to whichoutput.data
iff. theoutput.data.length > 1
. I think that's a rare case. If we really care about it, we can look to store the original version 1 AST to support round-tripping.This PR does not yet solve #1734 entirely -- for that, we need to pull in the
myst-compat
package more dynamically, so that it can be pulled in for oldmystmd
binaries.To Do
reduceOutputs
-- do we want this removingOutputs
nodes?blockMetadataTransform
that leaves emptyOutputs
nodes