make the run, restart and restartall buttons optional

[twyair]

i made the buttons that appear in every cell optional by adding the following boolean options to the config button_run, button_restart, button_restartall

the reason i need this is that i embed the cells in revealjs slides and these buttons just get in the way of actual content

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

[stevejpurves]

@twyair thanks for the PR 👏 . I've just left a comment so this better aligns with other options.

It would also be good to mention this in the documentation - e.g. by adding a note in docs/ui.rst if you are comfortable doing that?

[twyair]

@twyair thanks for the PR clap . I've just left a comment so this better aligns with other options.

It would also be good to mention this in the documentation - e.g. by adding a note in docs/ui.rst if you are comfortable doing that?

done. though I'm not sure if what I wrote is clear enough or worded well.

[welcome]

Congrats on your first merged pull request in this project! 🎉


Thank you for contributing, we are very proud of you! ❤️

[choldgraf]

this looks great - thanks for the addition @twyair

one quick question to see what you all think: what about embedding these configuration options in a parent key like "cellButtons", so the structure would be:

...
cellButtons: {
  mountRunButton: true,
  mountRestartButton: true,
  mountRestartallButton: true,
}
...

it feels a bit more clearly-scoped that way, since I could imagine a situation where other Thebe buttons might exist on the screen as well.

but - tell me if I am over-engineering configuration here :-) I don't feel strongly about it

[stevejpurves]

The configuration is quite large and flat @choldgraf so i like this idea. Should we go further and group all "ui" related options?

...
ui: { // or 'controls', or?
    mountStatusWidget: true,
    mountActivateButton: true,
    mountRunButton: true,
    mountRestartButton: true,
    mountRestartallButton: true
}
...

or perhaps:

...
mount: { 
    statusWidget: true,
    activateButton: true,
    runButton: true,
    restartButton: true,
    restartallButton: true
}
...

[choldgraf]

I'd be fine with a UI sub-field (or maybe "cellUI"?), Whatever is the right key name that provides an intuition for what is inside. (Though we should do a depreciation cycle if anything will move that has been released)