feature: code completion #503
Conversation
src/render.js
Outdated
| name: "stderr", | ||
| text: `Failed to execute. ${error} Please refresh the page.`, | ||
| }); | ||
| $cell.find("div.thebelab-busy").css("visibility", "hidden"); |
There was a problem hiding this comment.
this code is repeated in the execute catch block, would be good to extract to a function and use in both places e.g. clearOnError(error)
src/render.js
Outdated
| if (!kernel) { | ||
| console.debug("No kernel connected"); | ||
| setOutputText(); | ||
| events.trigger("request-kernel"); |
There was a problem hiding this comment.
I guess the only way to enable this feature is to have the kernel running, so it's reasonable to request it if its not there.
There was a problem hiding this comment.
thanks for the feedback!
right now it's doing the same thing the execute function is doing, how should I change it?
There was a problem hiding this comment.
I think leave it as-is 👍
|
@twyair I just tried this out in local dev and it work's great! One suggestion if you're able to extend this PR is to mention this in the docs - perhaps adding to a section to |
|
Brought this in! Thank @twyair I'll add the docs on the main branch |
No description provided.