-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] library global object rename #508
[MNT] library global object rename #508
Conversation
@stevejpurves could you give an idea of the major changes that have been made? I was expecting a pure "find/replace", but it seemed like there was also some content that had been added (e.g., the custom activate button). I think for things like "replace Also - perhaps we can allow |
@choldgraf thanks for the feedback. I added some comments and details in the PR description including a new TODO
|
Did some additional local testing and confirmed that setting |
planning on bringing this one in |
Was just gonna ask what needs to happen to move it through 🙂 anything you need help with? |
@stevejpurves did you implement this elsewhere or something? |
over zealous clean up on my part @choldgraf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me - I guess the main thing is to make sure we haven't missed a thebelab*
somewhere in there, but it seems good to me!
I added a couple of non-blocking comments, thanks for this helpful maintenance step!
@@ -1,5 +1,12 @@ | |||
# Changelog | |||
|
|||
## 0.8.3 - To be confirmed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense since thebelab
still works - we should do a minor version bump when thebelab
is removed though
37b45ac
to
5007499
Compare
Towards #230
Summary of Changes
thebe-
one for each instance ofthebelab-
selectorswindow.thebelab
is a reference towindow.thebe
.spec.js
have been changes to usethebe
objects/classes exclusivelyTODO: