Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate thebe-core #554

Merged
merged 108 commits into from
Feb 2, 2023
Merged

Integrate thebe-core #554

merged 108 commits into from
Feb 2, 2023

Conversation

stevejpurves
Copy link
Collaborator

@stevejpurves stevejpurves commented Jul 8, 2022 •
edited
Loading

Purpose

This PR will address #412 and #536 and in the process improve the build system. Changing the repo to be a monorepo will allow thebe-core to be built and published from here as well as making it easy to use it as a dependency in thebe. Once merged the thebe-core repo will be archived

Tasks

  • convert to a monorepo, ready to bring thebe-core in as a sub package
  • upgrade the build system
  • add thebe-core
  • refactor thebe to use thebe core
    • initial integration - cells are running
    • change notebook interface (notebook should return an array of promises, one for each cell, return the cell id along with the each promise)
    • fix busy spinners
    • re-enable code complete
    • Kernel Status
    • ensure events system aligns with previous
    • expose verbose events channel
    • get docs building again
  • setup eslint & prettier
  • get demo app running with thebe, rather than thebe-core
  • archive the thebe-core repo
  • get juptyerlite working again, see: BadZipFile Error when launching pyodide kernel via JuptyerLiteServer jupyterlite/jupyterlite#864
  • create thebe-core docs
    • add docs on thebe-lite

This was linked to issues Jul 8, 2022
Support connection to in-browser JupyterLite kernel #412
Closed
Integrate thebe-core back into thebe #536
Closed
@stevejpurves stevejpurves mentioned this pull request Jul 8, 2022
Closed
3 tasks
@stevejpurves stevejpurves mentioned this pull request Jul 18, 2022
Open
10 tasks
@rowanc1 rowanc1 mentioned this pull request Jul 18, 2022
Closed
This was referenced Jul 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@stevejpurves
update 📦🔒
ae62f08
@stevejpurves
mnt/pre workshop maint (#582)
3f581d6 
* tidying up build and adding some contibutor docs

* both `demos` are functional with new `thebe-core` interface

* added `thebe-core` docs

* add docs link in main readme
@stevejpurves
nasty scripts to move pyodide files into expected location
0c86052
@stevejpurves
actually call the lite post-build script
34b9794
@stevejpurves
ensure cells get the right rendermine registry
ac36b91
@stevejpurves
stop eating errors during widget build
e362a7c
@stevejpurves
separating server and session statuses
136fcfc
@stevejpurves
fix css for status
c912bb3
@stevejpurves
jupyterlite service worker now included in thebe-lite bundle
3f03d48
@stevejpurves
try/move thebe options * API (#586)
7a43e6a 
* fleshing out main sections

* move connection type optionsinto `thebe`
@stevejpurves
aligning core readme
14447b4
@stevejpurves
prep for initial publish on npm
bbd6954
@stevejpurves
core@0.1.0, thebe@0.9.0-rc1
f797e9d
@stevejpurves stevejpurves mentioned this pull request Dec 12, 2022
Open
18 tasks
@stevejpurves
Copy link
Collaborator Author

The remaining todos have been moved to issues #591 and #590.
Getting this into main will greatly help visibility and work towards 0.9.0.
An 0.8.x branch has been created for fixes to the current production version

@stevejpurves stevejpurves marked this pull request as ready for review February 2, 2023 13:03
@stevejpurves
Copy link
Collaborator Author

I have set the default on RTD to point to stable / v0.8.2 at the moment.

@stevejpurves stevejpurves merged commit 52609ff into main Feb 2, 2023
@stevejpurves stevejpurves deleted the feat/integrate-thebe-core branch February 2, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate thebe-core back into thebe Support connection to in-browser JupyterLite kernel
3 participants
@stevejpurves @agoose77 @rowanc1