🪝hooks aligned for ipynb or plain code
#600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
reactpackage provides a couple of hooks to help with ThebeNotebooks. One of the hooks dealt wthipynbfiles (INotebookContent) and had been developed further than the second hook that deals with plain code cells as an array of strings.This PR aligns the base features of the hooks (various execute methods, common approach to ref handling, etc..) while still providing the two different loading methods.
note the original
useNotebookfromSourcehas been renameduseNotebookfromSourceLegacyand marked as deprecated for now, but users should transition to the newuseNotebookFromSource(note fixed camel-casing).