-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use latest Jupyterlite with programatic options #612
Conversation
packages/lite/src/jlite.ts
Outdated
pipliteUrls: ['https://unpkg.com/@jupyterlite/pyodide-kernel@0.0.6/pypi/all.json'], | ||
}, | ||
}), | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be able to set the litePluginSettings
here? and this would be ahead of the @jupyterlite/pyodide-kernel-extension
being activated, so it should be able to pick up on these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it should be able to pick up on these?
Yes I would assume so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool - and yes I am seeing some impact of setting this but it's not loading the piplite
wheel from unpkg
for some reason.
i.e. with setting the litePluginSettings
here, on initializing the kernel two of the wheels are loaded from unpkg.com 👏 but it still looks to the /pypi/all.json
locally and still loads piplite
from there 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok so this kind of makes sense as litePluginSettings
is setting the pipliteUrls
i.e. where piplite
will load it's wheels from -- we need to also configure something separate to direct where the piplite
wheel itself will be loaded from...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opened jupyterlite/pyodide-kernel#42 to address this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have also started looking at the remote federated module loading, which I think I'll start in a separate PR on top of this one.
I'm just wondering though, if we put that remote loading in place it will immediately supercede this arrangement of build-time including the server extension while picking up the wheels from online - so it's just better to move to that now. Then AFAIK this will mean that the kernel can be specified by option at runtime, and also be interchangeable (i.e. we can load other xeus kernels too)
currently when trying to run I was expecting that setting the cc @jtpio does this seem like a reasonable approach? |
|
The screenshot suggests the name is malformed, but they seem to look good in the npm package: https://www.npmjs.com/package/@jupyterlite/pyodide-kernel?activeTab=code If you use the Maybe we could also check the Web Worker is correctly getting the wheel info. |
@jtpio yes the wheels look good in the package - what I am seeing though is webpack is adding them to my distribution and replacing the names with hashes, so my dist folder contains randomly hashed |
You might need to use the Asset Modules with a |
ok - so status after that last commit:
|
ok I have changed the pageconfig to set the |
merged #612 which addresses a lot of this but we still need some testing to see if that last todo on startup signalling has been achieved. |
The purpose of this PR is to update to using the latest
juptyerlite
codebase, this involves adjusting to the new organisation of the@juptyerlite/pyodide-kernel
and taking steps to specify the location of the wheels to load. This should be a big improvement over the previous implementation once in place, and the objective is to be able to load the latest wheels from CDN (possibly direct from unpkg.com).