Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update setup #642

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

shaielc
Copy link
Contributor

@shaielc shaielc commented Jun 20, 2023

Updated react-demo README following issue #638.

@welcome
Copy link

welcome bot commented Jun 20, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@stevejpurves
Copy link
Collaborator

this is great thanks @shaielc -- that boilerplate readme wasn;t useful before.

In light of this I've opened #643 as improving the docs for the other demos and surfacing all of that in the main docs site is a good thing to have

@stevejpurves
Copy link
Collaborator

bringing this in as apparently the preview will not work from a fork until the next version of the action we are using, hence the failure

@stevejpurves stevejpurves merged commit d2186e3 into jupyter-book:main Jun 20, 2023
@welcome
Copy link

welcome bot commented Jun 20, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants