Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs update : Installation copy-assets script #646

Merged

Conversation

shaielc
Copy link
Contributor

@shaielc shaielc commented Jun 23, 2023

Added the copy-thebe-assets script and referenced it in the relevant docs.

This resolves #645

If I am understanding correctly this stage is required whenever using either thebe-lite or thebe-core, so I put the script in thebe-core.

I have also made it optional to have thebe-lite installed but later I saw the it is a dependency of thebe-core which makes this change kinda moot

@shaielc shaielc changed the title docs update docs update : Installatio copy-assets script Jun 23, 2023
@shaielc shaielc changed the title docs update : Installatio copy-assets script docs update : Installation copy-assets script Jun 23, 2023
@shaielc
Copy link
Contributor Author

shaielc commented Jun 23, 2023

I have tested it by running:

cd packages/core
npm run build
npm pack
mkdir /tmp/test
cd /tmp/test
npm init
npm install <path to rep>/packages/core/thebe-core-0.2.3.tgz
npx copy-thebe-assets thebe

]
],
"bin": {
"copy-thebe-assets": "./bin/copy-thebe-assets.cjs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I am using this over in another myst-theme as well, and it will be nice to not have to copy this script all over the place!

@shaielc
Copy link
Contributor Author

shaielc commented Jun 25, 2023

The resource not accessible issue seems like a problen with the CI
I am guessing the cause is that this PR is from a fork

@stevejpurves
Copy link
Collaborator

@shaielc yes that's a limitation with the preview action.
Thanks for your PR!

@stevejpurves stevejpurves merged commit 673c1bd into jupyter-book:main Jun 26, 2023
@stevejpurves
Copy link
Collaborator

stevejpurves commented Jun 27, 2023

this will be released in v0.2.5 shortly, please disregard v0.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add copy-thebe-assets.cjs script to the package distro
3 participants