Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/cell kinds #659

Merged
merged 3 commits into from
Jul 6, 2023
Merged

feat/cell kinds #659

merged 3 commits into from
Jul 6, 2023

Conversation

stevejpurves
Copy link
Collaborator

This PR introduces a field kind into IThebeCells making it easier to discriminate between code and markdown at runtime. NonExecutableCell has now been renamed to MarkdownCell and the ThebeNotebook has some helpful accessors.

This change was prompted by use in myst-theme where management of the busy state is buggy due to the difficulty in being able to make this discrimination. See jupyter-book/myst-theme#160 and jupyter-book/myst-theme#155

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-07-06 13:01 UTC

@stevejpurves stevejpurves merged commit 600a932 into main Jul 6, 2023
@stevejpurves stevejpurves deleted the feat/cell-kinds branch July 6, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant