Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 update jupyterlite and jupyterlab dependencies #700

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

stevejpurves
Copy link
Collaborator

This will bring all the jupyter deps up to date and enable us to address #688 #689 #692

@stevejpurves stevejpurves self-assigned this Nov 14, 2023
Copy link
Contributor

github-actions bot commented Nov 14, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-20 17:48 UTC

@stevejpurves
Copy link
Collaborator Author

The last commit dropped tests from the thebe subpackage, there have been getting more difficult to maintain as the module eco system has changed under us but now jest is just not building and switching out to vitest is not an easy thing because of some of our upstream deps.

have disabled the tests until we can overhaul this, we should focus testing efforts on the underlying thebe-core and then get a suitable e2e style tst going with new tooling (maybe cypress) for the thebe subpackage. This should perhaph happen after we transition to ESM modules + bundles as our build targets.

@stevejpurves stevejpurves marked this pull request as ready for review November 20, 2023 17:39
@stevejpurves stevejpurves merged commit 30852d7 into main Nov 20, 2023
4 checks passed
@stevejpurves stevejpurves deleted the mnt/update-jlab-jlite-deps branch November 20, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant