default errors from server should be connection related only #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
stevejpurves
commented
Nov 20, 2023
•
stevejpurves
commented
- filter out execute related error events
- report all connection errors through this channel
- binder connect failures picked up
- report kernel/session start errors through this channel
- report disconnects through this channel
- update react demo to show processing different updates & errors
|
stevejpurves
force-pushed
the
feat/connect-errors
branch
from
0b21ac9
to
caf1a8b
Compare
|
made numerous changes to surface errors and statuses that should allow consuming apps to better manage failures. Updated the react demo app with some scrappy example components showing how they might be applied.
|
stevejpurves
force-pushed
the
feat/connect-errors
branch
from
ab66757
to
67a08ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.