Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAPI API specification #527

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Conversation

andrii-i
Copy link
Collaborator

@andrii-i andrii-i commented Jun 10, 2024

Adds OpenAPI specification of the current Jupyter Scheduler (v2.7.1) API contract. Documentation addition, does not change extension logic.

This formalizes an API contract and allows users and automated tools use the specification as a reference. For example, here's a human-friendly API specification generated by Swagger.io based on the specification: https://app.swaggerhub.com/apis/andrii-i/jupyter-scheduler/2.7.1-oas3. Future PRs should add a CI step building and publishing this human-readable API specification as a part of documentation.

@andrii-i andrii-i added enhancement New feature or request documentation Improvements or additions to documentation labels Jun 10, 2024
@andrii-i andrii-i marked this pull request as ready for review June 24, 2024 21:52
Copy link
Collaborator

@3coins 3coins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@andrii-i andrii-i merged commit 3a5c2ae into jupyter-server:main Jun 25, 2024
10 checks passed
@andrii-i andrii-i deleted the open-api branch June 25, 2024 21:52
andrii-i added a commit to andrii-i/jupyter-scheduler that referenced this pull request Jun 26, 2024
* Add OpenAPI API specification

* run pre-commit

* fix SortField, CreateJob indentation

* add missing /job_definitions/{job_definition_id}/jobs endpoint

* remove unused 400 and 404 errors

* Add security section specifying query or Authorization header token auth
andrii-i added a commit to andrii-i/jupyter-scheduler that referenced this pull request Jun 26, 2024
* Add OpenAPI API specification

* run pre-commit

* fix SortField, CreateJob indentation

* add missing /job_definitions/{job_definition_id}/jobs endpoint

* remove unused 400 and 404 errors

* Add security section specifying query or Authorization header token auth
andrii-i added a commit that referenced this pull request Jun 26, 2024
* Add OpenAPI API specification

* run pre-commit

* fix SortField, CreateJob indentation

* add missing /job_definitions/{job_definition_id}/jobs endpoint

* remove unused 400 and 404 errors

* Add security section specifying query or Authorization header token auth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants