Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PyPI trusted publisher and NPM provenance #511

Merged
merged 6 commits into from
Jun 19, 2023

Conversation

fcollonval
Copy link
Member

This adds the support for PyPI trusted publisher and NPM provenance on the releaser

Fixes #504
Fixes #506

@fcollonval
Copy link
Member Author

fcollonval commented Jun 19, 2023

This was successfully tested on https://github.com/jupyterlab/jupyterlab-git/actions/runs/5312255052/jobs/9616511151

NPM provenance:
image

For PyPI I don't know if there is a way to see a version was published using a trusted publisher.

@fcollonval fcollonval added the enhancement New feature or request label Jun 19, 2023
@fcollonval
Copy link
Member Author

On PyPI, you can actually check the security history tab (if you have proper rights):

image

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thank you!

@blink1073 blink1073 enabled auto-merge (squash) June 19, 2023 15:40
@blink1073 blink1073 merged commit 15ff2ef into jupyter-server:main Jun 19, 2023
@fcollonval fcollonval deleted the ft/trusted-publisher branch June 20, 2023 07:52
@fcollonval
Copy link
Member Author

Thanks a lot @blink1073 for fixing the PR and merging ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Npm Provenance Support for PyPI Trusted Publisher
2 participants