Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Release 1.15.0 is Broken #727

Closed
blink1073 opened this issue Mar 14, 2022 · 5 comments · Fixed by #728
Closed

Server Release 1.15.0 is Broken #727

blink1073 opened this issue Mar 14, 2022 · 5 comments · Fixed by #728
Labels

Comments

@blink1073
Copy link
Contributor

blink1073 commented Mar 14, 2022

Description

File "/opt/hostedtoolcache/Python/3.10.2/x64/lib/python3.10/site-packages/jupyter_core/application.py", line 174, in load_config_file
    self.log.debug("Searching %s for config files", self.config_file_paths)

  File "/opt/hostedtoolcache/Python/3.10.2/x64/lib/python3.10/site-packages/jupyter_server/extension/application.py", line 168, in config_file_paths
    return self.serverapp.config_file_paths

AttributeError: 'NoneType' object has no attribute 'config_file_paths'

Reproduce

Seen in https://github.com/jupyterlab/jupyterlab/runs/5536582051?check_suite_focus=true

Expected behavior

Context

Related to #715

@blink1073 blink1073 added the bug label Mar 14, 2022
@blink1073 blink1073 changed the title Server Release is Broken Server Release 1.15.0 is Broken Mar 14, 2022
@blink1073
Copy link
Contributor Author

cc @minrk

@blink1073 blink1073 reopened this Mar 14, 2022
@blink1073
Copy link
Contributor Author

I'm reverting the PR for now to get downstreams working again.

@minrk
Copy link
Contributor

minrk commented Mar 14, 2022

Thanks for reverting. I thought from other unconditional access to self.serverapp.attr that ExtensionApps couldn't be used without a serverapp, but I guess that's not true? I'll make sure that case is handled and tested, but I don't really understand how it makes sense.

@blink1073
Copy link
Contributor Author

Yeah, I'm not sure either, @Zsailer might have more insight.

@minrk
Copy link
Contributor

minrk commented Mar 14, 2022

I think #730 fixes it and includes a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants