Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards incompatibility with notebook #87

Open
Zsailer opened this issue Sep 12, 2019 · 1 comment
Open

Backwards incompatibility with notebook #87

Zsailer opened this issue Sep 12, 2019 · 1 comment

Comments

@Zsailer
Copy link
Member

Zsailer commented Sep 12, 2019

I've been coming across various places where jupyter_server diverges from notebook. I'm using this issue to track these differences. This will be turned into documentation in the future to help users migrate in places where we cannot add shims.

  • ConfigManager changed its config path from "nbconfig" to "serverconfig". (code)
    • Follow up question: should this be hardcoded into the config manager?
@rolweber
Copy link
Contributor

Re hard-coded "serverconfig", maybe we can define an attribute that a derived ConfigManager could overwrite. Then integrators are free to implement an NbConfigManager that sets it to "nbconfig" again.

Not sure whether it would make sense to pass it as a parameter with default value to the constructor of ConfigManager.

@Zsailer Zsailer added this to the 0.2.0 Release milestone Dec 2, 2019
@echarles echarles modified the milestones: 0.2.0 Release, 0.3.0 Release Jan 4, 2020
@Zsailer Zsailer removed this from the 0.3.0 Release milestone Apr 15, 2020
AnastasiaSliusar added a commit to AnastasiaSliusar/jupyter_server that referenced this issue May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants