Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase nbconvert and checkpoints coverage #1066

Merged
merged 2 commits into from
Nov 12, 2022

Conversation

blink1073
Copy link
Contributor

  • Install nbconvert prereqs on Ubuntu to increase coverage
  • Add explicit tests for all contents managers - found a bug in AsyncGenericCheckpointsMixin.restore_checkpoint

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 73.83%. Comparing base (44c3742) to head (5b8914d).
Report is 301 commits behind head on main.

Files with missing lines Patch % Lines
jupyter_server/services/contents/checkpoints.py 56.25% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
+ Coverage   73.09%   73.83%   +0.74%     
==========================================
  Files          64       64              
  Lines        8266     8267       +1     
  Branches     1640     1640              
==========================================
+ Hits         6042     6104      +62     
+ Misses       1819     1749      -70     
- Partials      405      414       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blink1073 blink1073 merged commit ca3c5b2 into jupyter-server:main Nov 12, 2022
@blink1073 blink1073 deleted the improve-cov branch November 12, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants