-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pytest-jupyter #1099
Use pytest-jupyter #1099
Conversation
Codecov ReportBase: 85.16% // Head: 79.99% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1099 +/- ##
==========================================
- Coverage 85.16% 79.99% -5.18%
==========================================
Files 124 68 -56
Lines 13095 8006 -5089
Branches 0 1585 +1585
==========================================
- Hits 11153 6404 -4749
+ Misses 1942 1182 -760
- Partials 0 420 +420
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The coverage was artificially inflated because we weren't using branch coverage with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're the man, @blink1073! Great stuff here!
@blink1073 do we need to change something in downstream package? This breaks the tests in JupyterLab: https://github.com/jupyterlab/jupyterlab/actions/runs/3572271760/jobs/6005278518 |
Never mind the trouble comes from the need to explicit the dependency packages otherwise pip is not able to resolve the packages to install. I opened jupyterlab/jupyterlab#13508 |
Use the fixtures from
pytest-jupyter
and re-expose them inpytest_plugin.py
for backward compatibility.Note, due to a chicken-and-egg problem, we need to forcibly install
pytest-jupyter[server]
for our downstream tests.