Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find an available port before starting event loop #1136

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

blink1073
Copy link
Contributor

Fixes #1126

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 79.94% // Head: 79.93% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (a37874f) compared to base (f6e280b).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1136      +/-   ##
==========================================
- Coverage   79.94%   79.93%   -0.01%     
==========================================
  Files          68       68              
  Lines        8053     8060       +7     
  Branches     1593     1598       +5     
==========================================
+ Hits         6438     6443       +5     
  Misses       1194     1194              
- Partials      421      423       +2     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 78.96% <88.88%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Zsailer
Copy link
Member

Zsailer commented Dec 19, 2022

This looks great, @blink1073! Thank you for tackling this issue. Merging!

@Zsailer Zsailer merged commit 2dd116f into jupyter-server:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL rendered and opened on wrong port when 8888 already in use
2 participants