Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff #1230

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Update ruff #1230

merged 2 commits into from
Mar 6, 2023

Conversation

blink1073
Copy link
Contributor

Update to latest ruff and clean up.

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Patch coverage: 45.23% and project coverage change: -0.17 ⚠️

Comparison is base (c71320a) 80.55% compared to head (fa76431) 80.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1230      +/-   ##
==========================================
- Coverage   80.55%   80.38%   -0.17%     
==========================================
  Files          68       68              
  Lines        8252     8252              
  Branches     1599     1599              
==========================================
- Hits         6647     6633      -14     
- Misses       1182     1195      +13     
- Partials      423      424       +1     
Impacted Files Coverage Δ
jupyter_server/auth/identity.py 86.04% <0.00%> (ø)
jupyter_server/extension/application.py 73.36% <0.00%> (ø)
jupyter_server/services/contents/manager.py 82.99% <0.00%> (ø)
jupyter_server/services/kernels/kernelmanager.py 81.81% <0.00%> (-0.91%) ⬇️
jupyter_server/utils.py 85.46% <0.00%> (ø)
...ter_server/services/kernels/connection/channels.py 61.06% <20.00%> (-2.00%) ⬇️
jupyter_server/files/handlers.py 85.45% <33.33%> (ø)
jupyter_server/serverapp.py 80.63% <50.00%> (ø)
jupyter_server/traittypes.py 62.90% <50.00%> (ø)
jupyter_server/auth/login.py 81.69% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More fun with lint - these changes look good - thank Steve.

@blink1073 blink1073 merged commit 4513527 into jupyter-server:main Mar 6, 2023
@blink1073 blink1073 deleted the bump-ruff-254 branch March 6, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants