Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send2trash now supports deleting from different filesystem type(#1290) #1291

Merged
merged 3 commits into from
Jun 27, 2023
Merged

send2trash now supports deleting from different filesystem type(#1290) #1291

merged 3 commits into from
Jun 27, 2023

Conversation

wqj97
Copy link
Contributor

@wqj97 wqj97 commented Jun 21, 2023

relate to #1290

@welcome
Copy link

welcome bot commented Jun 21, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@wqj97 wqj97 mentioned this pull request Jun 21, 2023
Closed
@blink1073
Copy link
Contributor

Thanks! Can you please bump the minimum version in pyproject.toml to the one that supports deleting directories?

@wqj97 wqj97 changed the title send2trash now supports deleting directories (#1290) send2trash now supports deleting from different filesystem type(#1290) Jun 22, 2023
@wqj97
Copy link
Contributor Author

wqj97 commented Jun 22, 2023 •
edited
Loading

Thanks! Can you please bump the minimum version in pyproject.toml to the one that supports deleting directories?

Sure, I will make a new commit later.
and Sorry about giving wrong title, correct title is "send2trash now supports deleting from different filesystem type"

@wqj97 wqj97 closed this Jun 24, 2023
@wqj97 wqj97 reopened this Jun 24, 2023
blink1073
blink1073 approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 8c90eb5 into jupyter-server:main Jun 27, 2023
@welcome
Copy link

welcome bot commented Jun 27, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@krassowski krassowski mentioned this pull request Oct 8, 2023
Closed
@krassowski krassowski mentioned this pull request Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wqj97 @blink1073