Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path resolver API #1331

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

krassowski
Copy link
Collaborator

@krassowski krassowski commented Sep 28, 2023

This patch demonstrates the scaffold of the new path resolver API endpoint proposed in #1280.

This depends on a sibling PR jupyter/jupyter_client#1005

Questions:

  • should I use self.kernel_manager or self.multi_kernel_manager? (these are not well documented in code)

In future we could include an entry point (e.g. traitlet) to define additional scopes (e.g. from remote file systems), but this is out of scope for this PR which focuses on distinguishing between a path from kernel and server.

@krassowski
Copy link
Collaborator Author

@meeseeksdev tag enhancement

Copy link

lumberbot-app bot commented Jan 31, 2024

Awww, sorry krassowski you do not seem to be allowed to do that, please ask a repository maintainer.

@krassowski krassowski changed the title [WIP] Path resolver API Path resolver API Jan 31, 2024
@krassowski
Copy link
Collaborator Author

Can a repository maintainer add labels to my pull requests or configure lumberbot to make it usable? It helps to see what is the CI status and reduces number of distracting spam emails about failure status.

@blink1073
Copy link
Contributor

I'm afk for the next few days but would merge such a PR. 😃

@krassowski
Copy link
Collaborator Author

Marking this as ready-for review because:

However, if the decision is to go with jupyter/jupyter_client#1006 and close this PR (along with jupyter/jupyter_client#1005) I would totally understand this.

@krassowski krassowski marked this pull request as ready for review March 25, 2024 11:54
@krassowski
Copy link
Collaborator Author

Another use case for this API is jupyterlab/jupyterlab#16235 - we currently cannot reliably reconcile the files returned by the debugger with the file system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants