Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing excessive logging from reading local files #1420

Merged
merged 2 commits into from
May 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jupyter_server/services/contents/fileio.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,8 @@ def _get_os_path(self, path):
------
404: if path is outside root
"""
self.log.debug("Reading path from disk: %s", path)
# This statement can cause excessive logging, uncomment if necessary when troubleshooting.
# self.log.debug("Reading path from disk: %s", path)
lresende marked this conversation as resolved.
Show resolved Hide resolved
root = os.path.abspath(self.root_dir) # type:ignore[attr-defined]
# to_os_path is not safe if path starts with a drive, since os.path.join discards first part
if os.path.splitdrive(path)[0]:
Expand Down
Loading