Fix default extension_name and validation #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
force-pushed
the
default-extension-name
branch
from
70a4527 to
0815d92
Compare
|
I don't get why CI is failing... |
|
Especially with this change: #176 |
|
Yeah, I suspect there's an issue in pytest. I see that 5.3.4 was built solely to revert a regression introduced in 5.3.3 and see that 5.3.3 (built just a few days prior to 5.3.4) appears to have other issues where folks are needing to pin to 5.3.2. Not sure why this isn't an issue for the Travis and Appveyor CI suites though. Since I just submitted #177, and its build-related anyway, I'm going to add the pin to 5.3.2 in that PR to see how it goes. |
|
Looks like pinning pytest worked in #177, thanks @kevin-bates. |
Zsailer
approved these changes
Jan 29, 2020
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
* add geojson renderer * add version * Bump to 0.13.7
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
Fix default extension_name and validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out the
ExtensionAppPR in voila, it looks like the default value forextension_namewas not picking upname.Also the validation should extract the value from the proposal.