Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace urljoin with url_path_join in extensionapp #304

Merged
merged 1 commit into from
Sep 8, 2020
Merged

replace urljoin with url_path_join in extensionapp #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions jupyter_server/extension/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import sys
import re
import logging
from urllib.parse import urljoin

from jinja2 import Environment, FileSystemLoader

Expand Down Expand Up @@ -197,7 +196,7 @@ def _default_static_url_prefix(self):
static_url = "static/{name}/".format(
name=self.name
)
return urljoin(self.serverapp.base_url, static_url)
return url_path_join(self.serverapp.base_url, static_url)

static_paths = List(Unicode(),
help="""paths to search for serving static files.
Expand Down
1 change: 0 additions & 1 deletion jupyter_server/extension/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from urllib.parse import urljoin
from jupyter_server.base.handlers import FileFindHandler
from jinja2.exceptions import TemplateNotFound

Expand Down