Add TermSocket back from nbclassic #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jupyter-server#313 removed too much to nbclassic. Reverting part of it allows JupyterLab to work with the standalone jupyter server (and JupyterLab examples to work without loading other extensions like nbclassic).
jasongrout
added a commit
to jasongrout/nbclassic
that referenced
this pull request
Sep 29, 2020
jupyter#31 moved a bit too much from jupyter server to nbclassic. This moves some back. See also jupyter-server/jupyter_server#314
|
I'm actually glad to see this compensating pull request as we would lose the ability to cull terminals once the corresponding notebook PR was ported. Thanks. |
|
Great! |
|
If it's all right with you, I'll push out a release with this. |
|
Totally fine Jason - thanks. |
|
This is now published as 1.0.3 |
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
Add TermSocket back from nbclassic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#313 removed too much to nbclassic. Reverting part of it allows JupyterLab to work with the standalone jupyter server (and JupyterLab examples to work without loading other extensions like nbclassic).