Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #340 on branch 1.0.x (add check_origin handler to gateway WebSocketChannelsHandler) #359

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Backport PR #340 on branch 1.0.x (add check_origin handler to gateway WebSocketChannelsHandler) #359

merged 1 commit into from
Dec 10, 2020

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #340: add check_origin handler to gateway WebSocketChannelsHandler

@Zsailer Zsailer mentioned this pull request Dec 10, 2020
Closed
Zsailer
Zsailer approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems things are hanging due to issues raised in #357. Merging, since this PR is unrelated.

@Zsailer Zsailer merged commit 36d8769 into jupyter-server:1.0.x Dec 10, 2020
@meeseeksmachine meeseeksmachine deleted the auto-backport-of-pr-340-on-1.0.x branch April 20, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zsailer Zsailer Zsailer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meeseeksmachine @Zsailer @kevin-bates