Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip default value for open_browser in extensions #377

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Flip default value for open_browser in extensions #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions jupyter_server/extension/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,11 @@ class method. This method can be set as a entry_point in
# is launched directly (using its `launch_instance` method).
serverapp_config = {}

# Some subclasses will likely ovrride this trait to flip
# the default value to True if they offer a browser
# Some subclasses will likely override this trait to flip
# the default value to False if they don't offer a browser
# based frontend.
open_browser = Bool(
False,
True,
help="""Whether to open in a browser after starting.
The specific browser used is platform dependent and
determined by the python standard library `webbrowser`
Expand Down Expand Up @@ -497,4 +497,4 @@ def launch_instance(cls, argv=None, **kwargs):
"{ext_name} is running without loading "
"other extensions.".format(ext_name=cls.name)
)
serverapp.start()
serverapp.start()