Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update changelog for 1.2.2 #387

Merged
merged 1 commit into from
Jan 15, 2021
Merged

update changelog for 1.2.2 #387

merged 1 commit into from
Jan 15, 2021

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Jan 15, 2021

No description provided.

@Zsailer Zsailer requested a review from kevin-bates January 15, 2021 00:59
kevin-bates
kevin-bates approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you Zach!

@Zsailer Zsailer merged commit 1b7f6fe into master Jan 15, 2021
@Zsailer
Copy link
Member Author

Zsailer commented Jan 15, 2021 •
edited
Loading

@minrk - it looks like our tests are failing using PyPy (Python 3.9) after to the latest release of pyzmq (21.0.x).

Here's the traceback:

[IPKernelApp] ERROR | Invalid Message
Traceback (most recent call last):
  File "/opt/hostedtoolcache/PyPy/3.6.12/x64/site-packages/ipykernel/kernelbase.py", line 227, in dispatch_shell
    msg = self.session.deserialize(msg, content=True, copy=False)
  File "/opt/hostedtoolcache/PyPy/3.6.12/x64/site-packages/jupyter_client/session.py", line 924, in deserialize
    self._add_digest(signature)
  File "/opt/hostedtoolcache/PyPy/3.6.12/x64/site-packages/jupyter_client/session.py", line 867, in _add_digest
    self.digest_history.add(signature)
TypeError: unhashable type: '_cffi_backend.buffer'

Do you have any insights to what's going on?

@jtpio jtpio deleted the changelog-1.2.2 branch January 30, 2021 10:16
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
session deletion with culling (jupyter-server#387)
9f1ee81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zsailer @kevin-bates