ExtensionManager: load default config manager by default #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use traitlets for defaults, loading config_managers - load default config manager with default config path by default - remove semi-private attributes transparently exposed with public getters
minrk
force-pushed
the
default-config-manager
branch
from
1e5b811 to
08bfe34
Compare
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 77.68% 77.70% +0.02%
==========================================
Files 106 106
Lines 9276 9280 +4
Branches 1001 1002 +1
==========================================
+ Hits 7206 7211 +5
+ Misses 1711 1710 -1
Partials 359 359
Continue to review full report at Codecov.
|
Zsailer
approved these changes
May 3, 2021
|
Thanks, @minrk! 🚀 |
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
ExtensionManager: load default config manager by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in favor of making them public.
This way a fully default
ExtensionManager()will find all extensions by default, without needing to instantiate a config manager first.