-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable a way to run a task when an io_loop is created #531
Conversation
@pumpkindle, can you give us a bit more detail here—maybe an example of why you'd want this? |
@Zsailer hello, one way of using this is when I want to create a background async_task when ioloop is ready, for example to create and supervisor a suprocess when ioloop is ready.(an extension may use this feature for such things) as far as I can see it, the ioloop will be waiting for request after jupyter server is started, and can not use ioloop util then. |
Interesting. Maybe what makes sense here is to expose the This would mean adding a |
@Zsailer yes, you're right, expose |
@eastonsuo, would you like to update your PR with this fix? |
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
=========================================
Coverage ? 76.33%
=========================================
Files ? 110
Lines ? 9816
Branches ? 1067
=========================================
Hits ? 7493
Misses ? 1943
Partials ? 380
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
usage:
in extensionApp.initialize_handlers: