small test changes #541
Merged
small test changes #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 76.34% 76.60% +0.26%
==========================================
Files 110 109 -1
Lines 9819 9807 -12
Branches 1067 1063 -4
==========================================
+ Hits 7496 7513 +17
+ Misses 1943 1915 -28
+ Partials 380 379 -1
Continue to review full report at Codecov.
|
|
(rebased and hopefully fixed the check-manifest test) |
|
(one more commit to fix the downstream tests which were broken by the top-level contest.py file) |
* the dependencies are specified in setup.cfg rather than .py
* fix defining pytest_plugins in non-top-level conftest file (pytest 3+) https://docs.pytest.org/en/6.2.x/deprecations.html#pytest-plugins-in-non-top-level-conftest-files * update to pytest 6 as this was the first version to support pyproject.toml https://docs.pytest.org/en/stable/changelog.html#id123
Zsailer
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
This is a fantastic contributions. Thanks so much, @oliver-sanders. Merging away!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small test changes:
Use the hash of the
setup.pyfile for pip caching (rather thansetup.py) in all actions.One action is already using the
setup.cfgfile:jupyter_server/.github/workflows/check-release.yml
Line 27 in 51e3ec3
The others aren't:
jupyter_server/.github/workflows/python-linux.yml
Line 34 in 51e3ec3
The pip environment may have been frozen for a little while because of this?
Define
pytest_pluginsin a top-level conftest file to support pytest 4+.Pin pytest>=6 as earlier versions ignored the configuration in the
pytest.tomlfile.Run doctests in pytest (0.34% coverage increase 😆).
Test against Python 3.10-dev (except on Windows due to pywin32 incompatibility)
Bump the versions of checkout/cache/setup-python actions.