Respect reraise setting

[vidartf]

We have this nice setting for having extension load failure raise errors instead of silently failing. We should respect it 😄

[kevin-bates]

😄 - good catch Vidar. Just had the one comment. I was not aware of this option.

[codecov-commenter]

Codecov Report

Merging #571 (1aa5512) into master (90f619c) will increase coverage by 0.40%.
The diff coverage is 98.21%.

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage   77.12%   77.52%   +0.40%     
==========================================
  Files         109      109              
  Lines       10115    10171      +56     
  Branches     1089     1096       +7     
==========================================
+ Hits         7801     7885      +84     
+ Misses       1929     1897      -32     
- Partials      385      389       +4     

Impacted Files	Coverage Δ
jupyter_server/tests/test_terminal.py	98.79% <66.66%> (ø)
jupyter_server/extension/manager.py	93.89% <100.00%> (+4.09%)	⬆️
jupyter_server/serverapp.py	65.53% <100.00%> (ø)
jupyter_server/tests/extension/test_app.py	98.24% <100.00%> (ø)
jupyter_server/tests/extension/test_manager.py	100.00% <100.00%> (ø)
jupyter_server/tests/services/kernels/test_cull.py	100.00% <100.00%> (ø)
...ter_server/tests/services/contents/test_manager.py	96.95% <0.00%> (-0.34%)	⬇️
jupyter_server/terminal/terminalmanager.py	87.50% <0.00%> (+1.25%)	⬆️
jupyter_server/extension/application.py	74.31% <0.00%> (+1.37%)	⬆️
...pyter_server/tests/extension/mockextensions/app.py	93.93% <0.00%> (+3.03%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f619c...1aa5512. Read the comment docs.

[kevin-bates]

Thanks Vidar - the updates look good. I'd prefer to have someone more familiar with extensions take a look as well given the move of serverapp into an instance attribute (which makes good sense to me).

cc: @Zsailer, @echarles

[echarles]

Great! I like having the server starting by defaullt although some extensions fail. Keeping reraise_server_extension_failures to False by default is good. Thx @vidartf for honouring a True value in this PR.

[blink1073]

@vidartf, can you please rebase this to pick up the formatting changes from #575? You'll have to install pre-commit locally to pick up the new formatting rules.

[vidartf]

Rebased now. I just had to get my antivirus to stop deadlocking pre-commit 👍

[blink1073]

Nice, thank you! I'll wait for @Zsailer to have a look since there are API changes

[blink1073]

Merging to get CI running again, we can walk back the API changes before releasing if needed. Thanks!