-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non-empty directory deletion through settings #574
Allow non-empty directory deletion through settings #574
Conversation
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
==========================================
+ Coverage 77.12% 77.32% +0.19%
==========================================
Files 109 109
Lines 10115 10137 +22
Branches 1089 1093 +4
==========================================
+ Hits 7801 7838 +37
+ Misses 1929 1909 -20
- Partials 385 390 +5
Continue to review full report at Codecov.
|
FYI this now has a merge conflict from the formatting changes in #575 |
Fixes jupyter-server#570 More robust unit tests
40bd677
to
6428ebc
Compare
@blink1073 CI tests failing are identical to the one on master. Is this one good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Let's wait for @Zsailer to have a look as well
Co-authored-by: Kevin Bates <kbates4@gmail.com>
Fixes #570