Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dependency on NBConvert versions for REST API test #601

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Nov 1, 2021

Relaxes one of the NBConvert API tests, so it's not dependent on NBConvert versions and only tests the REST API.

@Zsailer
Copy link
Member Author

Zsailer commented Nov 1, 2021

Should fix the test failures in #599

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #601 (968a637) into master (29be9c6) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   77.34%   77.40%   +0.06%     
==========================================
  Files         110      110              
  Lines       10250    10251       +1     
  Branches     1257     1258       +1     
==========================================
+ Hits         7928     7935       +7     
+ Misses       1926     1918       -8     
- Partials      396      398       +2     
Impacted Files Coverage Δ
...upyter_server/tests/services/nbconvert/test_api.py 100.00% <100.00%> (ø)
jupyter_server/services/kernels/kernelmanager.py 81.84% <0.00%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29be9c6...968a637. Read the comment docs.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense (to relax the checks) - thank you!

@Zsailer Zsailer merged commit 6bd015c into jupyter-server:master Nov 1, 2021
@Zsailer Zsailer deleted the nbconvert-test branch January 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants