You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_list_notebooks was failing on file systems with unicode
normalization different from the encoding used in the strings. In particular on macOS with HFS+ I got failures for four of the file names. This is because HFS+ uses normalization form D while normalization form C is more commonly used, especially on Linux.
By normalizing the name and path read from disk to NFC we avoid the mismatch as long as no NFD strings are added to the dirs tuples. There are other unicode normal forms and normalization is not necessarily invertible so this is not a perfect solution.
I can think of two alternative solutions:
Refrain from using any unicode symbols that have different representations in the various normal forms.
Write temporary files to disk somewhere, the read back the paths and filenames and use those instead of the original strings in the test.
test_list_notebooks was failing on file systems with unicode
normalization different from the encoding used in the strings. In
particular on macOS with HFS+ I got failures for four of the file names.
This is because HFS+ uses normalization form D while normalization form
C is more commonly used, especially on Linux.
By normalizing the name and path read from disk to NFC we avoid the
mismatch as long as no NFD strings are added to the `dirs` tuples.
There are other unicode normal forms and normalization is not
necessarily invertible so this is not a perfect solution.
I can think of two alternative solutions:
1. Refrain from using any unicode symbols that have different
representations in the various normal forms.
2. Write temporary files to disk somewhere, the read back the paths and
filenames and use those instead of the original strings in the test.
Thanks for submitting your first pull request! You are awesome! 🤗
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_list_notebooks was failing on file systems with unicode
normalization different from the encoding used in the strings. In particular on macOS with HFS+ I got failures for four of the file names. This is because HFS+ uses normalization form D while normalization form C is more commonly used, especially on Linux.
By normalizing the name and path read from disk to NFC we avoid the mismatch as long as no NFD strings are added to the
dirstuples. There are other unicode normal forms and normalization is not necessarily invertible so this is not a perfect solution.I can think of two alternative solutions: