Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nbconvert handler run_sync() #667

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

davidbrochart
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2022

Codecov Report

Merging #667 (72e94b0) into main (923a828) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
- Coverage   77.85%   77.81%   -0.05%     
==========================================
  Files         110      110              
  Lines       10415    10415              
  Branches     1401     1403       +2     
==========================================
- Hits         8109     8104       -5     
- Misses       1916     1922       +6     
+ Partials      390      389       -1     
Impacted Files Coverage Δ
jupyter_server/nbconvert/handlers.py 25.00% <50.00%> (ø)
jupyter_server/services/kernels/kernelmanager.py 80.63% <0.00%> (-1.91%) ⬇️
jupyter_server/tests/services/kernels/test_api.py 94.92% <0.00%> (-1.45%) ⬇️
jupyter_server/utils.py 66.47% <0.00%> (+0.56%) ⬆️
jupyter_server/pytest_plugin.py 85.83% <0.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 923a828...72e94b0. Read the comment docs.

@Zsailer
Copy link
Member

Zsailer commented Jan 18, 2022

Thank you, @davidbrochart. The test failures are unrelated. They appear to be caused by jupyter/jupyter_client#732

1 similar comment
@Zsailer
Copy link
Member

Zsailer commented Jan 18, 2022

Thank you, @davidbrochart. The test failures are unrelated. They appear to be caused by jupyter/jupyter_client#732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants