Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebSocket wire protocol documentation #693

Merged
merged 6 commits into from
Feb 8, 2022

Conversation

davidbrochart
Copy link
Contributor

@davidbrochart davidbrochart commented Feb 7, 2022

docs/source/developers/websocket-protocols.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@jasongrout jasongrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a few suggestions for clarification.

docs/source/developers/websocket-protocols.rst Outdated Show resolved Hide resolved
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #693 (6858900) into main (6d2276c) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
- Coverage   77.34%   77.17%   -0.18%     
==========================================
  Files         110      110              
  Lines       10542    10542              
  Branches     1427     1427              
==========================================
- Hits         8154     8136      -18     
- Misses       1988     2001      +13     
- Partials      400      405       +5     
Impacted Files Coverage Δ
jupyter_server/services/contents/filemanager.py 68.61% <0.00%> (-1.61%) ⬇️
jupyter_server/services/kernels/handlers.py 56.76% <0.00%> (-1.10%) ⬇️
...ter_server/tests/services/contents/test_manager.py 96.01% <0.00%> (-0.94%) ⬇️
jupyter_server/serverapp.py 65.47% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2276c...6858900. Read the comment docs.

davidbrochart and others added 2 commits February 8, 2022 01:45
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
@davidbrochart
Copy link
Contributor Author

Thanks @jasongrout !

@blink1073 blink1073 merged commit 0ab0e1e into jupyter-server:main Feb 8, 2022
@davidbrochart davidbrochart deleted the doc branch February 8, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants