Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handler in simple extension examples #750

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

andreyvelich
Copy link
Contributor

I fixed problem with error handler in simple extension.
We can use write_error instead of write, so status_code and status_message will be populated.
Also, I added few unit tests for simple_ext1.

cc @Zsailer

@welcome
Copy link

welcome bot commented Mar 23, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@Zsailer Zsailer requested a review from echarles March 23, 2022 14:19
Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failing CI on build (windows-latest, 3.10 is not related to this PR. Thx @andreyvelich

@echarles echarles merged commit 3eaea4b into jupyter-server:main Mar 23, 2022
@andreyvelich andreyvelich deleted the fix-simple-examples branch March 23, 2022 16:35
@welcome
Copy link

welcome bot commented Mar 23, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants