Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include explicit package data #757

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

blink1073
Copy link
Contributor

Workaround for pypa/setuptools#3200

@blink1073 blink1073 added the bug label Mar 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #757 (c211dbb) into main (cd1b1b8) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   70.68%   70.56%   -0.12%     
==========================================
  Files          62       62              
  Lines        7620     7620              
  Branches     1218     1218              
==========================================
- Hits         5386     5377       -9     
- Misses       1860     1872      +12     
+ Partials      374      371       -3     
Impacted Files Coverage Δ
jupyter_server/base/zmqhandlers.py 52.91% <0.00%> (-4.24%) ⬇️
jupyter_server/services/kernels/handlers.py 58.86% <0.00%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd1b1b8...c211dbb. Read the comment docs.

@blink1073
Copy link
Contributor Author

I'm not going to release this until Monday, regardless of the whether setuptools gets a release, because it only affects new wheels built from our sdist. I don't want to risk making a release on Friday.

@blink1073 blink1073 merged commit 936e4d6 into jupyter-server:main Mar 25, 2022
@blink1073 blink1073 deleted the fix-package-include branch March 25, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants