Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of dev version #913

Merged

Conversation

blink1073
Copy link
Contributor

No description provided.

@blink1073
Copy link
Contributor Author

cc @echarles, you'll either have to do this or drop using dev versions for now in nbclassic.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #913 (3e17230) into main (204a004) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
- Coverage   72.37%   72.29%   -0.08%     
==========================================
  Files          65       65              
  Lines        7978     7978              
  Branches     1332     1332              
==========================================
- Hits         5774     5768       -6     
- Misses       1796     1804       +8     
+ Partials      408      406       -2     
Impacted Files Coverage Δ
jupyter_server/services/kernels/kernelmanager.py 78.64% <0.00%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 204a004...3e17230. Read the comment docs.

@blink1073 blink1073 enabled auto-merge (squash) July 11, 2022 14:42
@blink1073 blink1073 merged commit e49e0dd into jupyter-server:main Jul 11, 2022
@blink1073 blink1073 deleted the fix-check-release-dev-version branch July 11, 2022 14:50
@blink1073
Copy link
Contributor Author

@meeseeksdev please backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyter_server that referenced this pull request Jul 11, 2022
blink1073 added a commit that referenced this pull request Jul 11, 2022
Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants