-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept and manage cookies when requesting gateways #969
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov Report
@@ Coverage Diff @@
## main #969 +/- ##
==========================================
+ Coverage 72.30% 72.49% +0.19%
==========================================
Files 64 64
Lines 8136 8185 +49
Branches 1358 1371 +13
==========================================
+ Hits 5883 5934 +51
+ Misses 1843 1839 -4
- Partials 410 412 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wjsi - this looks good - I just had the one suggestion.
If you could also update with main
, that would be great. Thank you.
0e460ba
to
e86d938
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you @wjsi!
I suspect the test failure is unrelated, but holding off on the merge until we can confirm tomorrow.
Yep, thanks @wjsi and @kevin-bates! |
This PR adds an
accept_cookies
argument toGatewayClient
class. Once enabled,GatewayClient
accepts and manages cookie expiration when receiving cookies generated by load balancers serving notebook gateways. These cookies will be sent back in request headers for load balancers to decide which backend node to use.Purposes and discussions in #967.