Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #293.
Currently, the frontend expects a stream output "text" field to be a YText:
jupyter_ydoc/javascript/src/ycell.ts
Lines 791 to 799 in b208786
But the backend expects it to be a YArray:
jupyter_ydoc/jupyter_ydoc/ynotebook.py
Lines 165 to 166 in b208786
Creating a notebook with:
And opening it in JupyterLab takes a few seconds and shows the following output:
Which is wrong because it should be one single line.
With this PR, the notebook opens instantly, showing a single line:
@trungleduc I remember you updated the snapshots somewhere because you saw a mismatch like that. Was it in jupyter-collaboration?